[
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279468#comment-16279468
]
Appy commented on HBASE-19417:
------------------------------
+1
Great stuff.
bq. It turns out that SecureBulkLoadManager.java has the calls to pre / post
hooks. So in patch v8 I narrowed the calls in RSRpcServices.
oh! cool.
{quote}
bq. CPs in 2.0 are radically different than 1.x
Now I know
{quote}
Oh yeah, it's like any old CP will very very likely not work with 2.0. Will
need a recompile. Base*Observer(s) are gone, many methods have changed, and IA
of many classes changed.
> Remove boolean return value from postBulkLoadHFile hook
> -------------------------------------------------------
>
> Key: HBASE-19417
> URL: https://issues.apache.org/jira/browse/HBASE-19417
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Ted Yu
> Attachments: 19417.v1.txt, 19417.v2.txt, 19417.v3.txt, 19417.v4.txt,
> 19417.v5.txt, 19417.v6.txt, 19417.v7.txt, 19417.v8.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the
> override of loaded should be placed inside else block:
> {code}
> } else {
> // secure bulk load
> map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region,
> request);
> }
> BulkLoadHFileResponse.Builder builder =
> BulkLoadHFileResponse.newBuilder();
> if (map != null) {
> loaded = true;
> }
> {code}
> This issue is to address the review comment.
> After several review iterations, here are the changes:
> * Return value of boolean for postBulkLoadHFile() hook are changed to void.
> * Coprocessor hooks (pre and post) are added for the scenario where bulk load
> manager is used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
