[ 
https://issues.apache.org/jira/browse/HBASE-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279904#comment-16279904
 ] 

Chia-Ping Tsai commented on HBASE-18112:
----------------------------------------

{code}
    int frameLengthInt = (int) frameLength;
    if (in.readableBytes() < frameLengthInt) { // here
      return;
    }

    in.skipBytes(FRAME_LENGTH_FIELD_LENGTH);
{code}
The bounds check should consider the {{FRAME_LENGTH_FIELD_LENGTH}} as the index 
will be moved later.
This bugs result in some failed tests after [~stack] makes netty engine default 
in hbase2 (HBASE-19323)

> Write RequestTooBigException back to client for NettyRpcServer
> --------------------------------------------------------------
>
>                 Key: HBASE-18112
>                 URL: https://issues.apache.org/jira/browse/HBASE-18112
>             Project: HBase
>          Issue Type: Sub-task
>          Components: IPC/RPC
>            Reporter: Duo Zhang
>            Assignee: Toshihiro Suzuki
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18112-v2.patch, HBASE-18112-v2.patch, 
> HBASE-18112-v2.patch, HBASE-18112-v3.patch, HBASE-18112-v3.patch, 
> HBASE-18112-v4.patch, HBASE-18112-v4.patch, HBASE-18112-v5.patch, 
> HBASE-18112.patch
>
>
> For now we just close the connection so NettyRpcServer can not pass TestIPC.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to