[jira] [Commented] (HBASE-18112) Write RequestTooBigException back to client for NettyRpcServer

[Duo Zhang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280181#comment-16280181
 ] 

Duo Zhang commented on HBASE-18112:
-----------------------------------

I think the approach here is correct. +1.

And mind also doing a simplification?

{code}
    // extract frame
    int readerIndex = in.readerIndex();
    ByteBuf frame = in.retainedSlice(readerIndex, frameLengthInt);
    in.readerIndex(readerIndex + frameLengthInt);

    out.add(frame);
{code}

Can be simplified to
{code}
    // extract frame
    out.add(in.readRetainedSlice(frameLengthInt));
{code}

Thanks.

> Write RequestTooBigException back to client for NettyRpcServer
> --------------------------------------------------------------
>
>                 Key: HBASE-18112
>                 URL: https://issues.apache.org/jira/browse/HBASE-18112
>             Project: HBase
>          Issue Type: Sub-task
>          Components: IPC/RPC
>            Reporter: Duo Zhang
>            Assignee: Toshihiro Suzuki
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18112-v2.patch, HBASE-18112-v2.patch, 
> HBASE-18112-v2.patch, HBASE-18112-v3.patch, HBASE-18112-v3.patch, 
> HBASE-18112-v4.patch, HBASE-18112-v4.patch, HBASE-18112-v5.patch, 
> HBASE-18112.addendum.patch, HBASE-18112.patch
>
>
> For now we just close the connection so NettyRpcServer can not pass TestIPC.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)