[
https://issues.apache.org/jira/browse/HBASE-19435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281517#comment-16281517
]
ramkrishna.s.vasudevan commented on HBASE-19435:
------------------------------------------------
bq.I'm not sure exactly where it is happening, but a major compaction is run
and then some of these file connections are closed.
Thanks for doing it. I think it is important in this case.
bq.https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java#L1135
is where the code to disable cache after 60 seconds of throwing IOExceptions.
If all attempts to refresh channel threw an IOException, the cache still would
be disabled here.
Good. i did not know this was there. Need to fix this then.
bq.buffer.limit(bufLimit);
Minor nit : This may not be inside try/catch.
So if the filechannel.close() - I see is for tests only. LGTM.
> Reopen Files for ClosedChannelException in BucketCache
> ------------------------------------------------------
>
> Key: HBASE-19435
> URL: https://issues.apache.org/jira/browse/HBASE-19435
> Project: HBase
> Issue Type: Bug
> Components: BucketCache
> Affects Versions: 2.0.0, 1.3.1
> Reporter: Zach York
> Assignee: Zach York
> Attachments: HBASE-19435.master.001.patch,
> HBASE-19435.master.002.patch, HBASE-19435.master.003.patch,
> HBASE-19435.master.004.patch, HBASE-19435.master.005.patch
>
>
> When using the FileIOEngine for BucketCache, the cache will be disabled if
> the connection is interrupted or closed. HBase will then get
> ClosedChannelExceptions trying to access the file. After 60s, the RS will
> disable the cache. This causes severe read performance degradation for
> workloads that rely on this cache. FileIOEngine never tries to reopen the
> connection. This JIRA is to reopen files when the BucketCache encounters a
> ClosedChannelException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
