[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286725#comment-16286725
]
Appy commented on HBASE-19483:
------------------------------
Review:
- Add documentation in hbase book. [RS Group
section|http://hbase.apache.org/book.html#rsgroup] should talk about
permissions too.
- post*() hooks are more useful if they also pass the result as a param. For
eg. postListRSGroup() should be postListRSGroup(List<RSGroupInfo>). Similarly
others.
----
Bigger questions than this change, no need to block patch on this. Can be done
in separate jiras:
- Note that adding params to post*() means CPs can modify them. First question
is - do we want to allow them to be modified?
- Irrespective to above answer, i think it'll be good to make RSGroupInfo to be
immutable class and use builder pattern (it's small class which means the
change will be small).
- {{if(((MasterEnvironment)getEnvironment()).supportGroupCPs) }}
[~enis] Since CP in 2.0 are broken left and right (and we'll have to solve
legacy issue more holistically), we can get rid of "supportGroupCPs"?
> Add proper privilege check for rsgroup commands
> -----------------------------------------------
>
> Key: HBASE-19483
> URL: https://issues.apache.org/jira/browse/HBASE-19483
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Guangxu Cheng
> Attachments: HBASE-19483.master.001.patch
>
>
> Currently list_rsgroups command can be executed by any user.
> This is inconsistent with other list commands such as list_peers and
> list_peer_configs.
> We should add proper privilege check for list_rsgroups command.
> privilege check should be added for get_table_rsgroup / get_server_rsgroup /
> get_rsgroup commands.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
