[
https://issues.apache.org/jira/browse/HBASE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295363#comment-16295363
]
stack commented on HBASE-19532:
-------------------------------
bq. How you even come across this problem?
^^
bq. When left is not meta and right is meta, +1 is returned - this keeps
symmetry with the above.
Seems wrong to me.
bq. I would think coverage of the modified test is good enough.
Disagree. See above for why.
> AssignProcedure#COMPARATOR may produce incorrect sort order
> -----------------------------------------------------------
>
> Key: HBASE-19532
> URL: https://issues.apache.org/jira/browse/HBASE-19532
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 19532.v1.txt
>
>
> The intention of AssignProcedure#COMPARATOR is to put the regions in the
> following order:
> meta regions
> system table regions
> user table regions
> However, the current implementation may produce incorrect sort order.
> With the modified test, the test fails with:
> {code}
> testComparatorWithMetas(org.apache.hadoop.hbase.master.snapshot.TestAssignProcedure)
> Time elapsed: 0.038 sec <<< FAILURE!
> junit.framework.AssertionFailedError
> at
> org.apache.hadoop.hbase.master.snapshot.TestAssignProcedure.testComparatorWithMetas(TestAssignProcedure.java:88)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
