[
https://issues.apache.org/jira/browse/HBASE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295616#comment-16295616
]
stack commented on HBASE-19532:
-------------------------------
Your additions to the test seem useless to me. You break the pattern where we
create and add to the array immediately. Did the original rearrangement cause a
mis-ordering of regions? You don't even say.
There is only one sort going on. Your additions make no new perturbation in the
test I added as best as I can tell from review. You seem to have spotted a
problem in the checked in code but you don't add new clear permutations running
added sorts to ensure right answer.
> AssignProcedure#COMPARATOR may produce incorrect sort order
> -----------------------------------------------------------
>
> Key: HBASE-19532
> URL: https://issues.apache.org/jira/browse/HBASE-19532
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 19532.v1.txt, 19532.v2.txt
>
>
> The intention of AssignProcedure#COMPARATOR is to put the regions in the
> following order:
> meta regions
> system table regions
> user table regions
> However, the current implementation may produce incorrect sort order.
> With the modified test, the test fails with:
> {code}
> testComparatorWithMetas(org.apache.hadoop.hbase.master.snapshot.TestAssignProcedure)
> Time elapsed: 0.038 sec <<< FAILURE!
> junit.framework.AssertionFailedError
> at
> org.apache.hadoop.hbase.master.snapshot.TestAssignProcedure.testComparatorWithMetas(TestAssignProcedure.java:88)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
