[
https://issues.apache.org/jira/browse/HBASE-19621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303151#comment-16303151
]
Ted Yu commented on HBASE-19621:
--------------------------------
{code}
+ public ReplicationPeerConfigBuilder addConfiguration(String key, String
value) {
+ this.configuration.put(key, value);
{code}
Since key may already exist in this.configuration, method name does't seem to
be accurate.
How about naming it putConfiguration() ?
> Revisit the methods in ReplicationPeerConfigBuilder
> ---------------------------------------------------
>
> Key: HBASE-19621
> URL: https://issues.apache.org/jira/browse/HBASE-19621
> Project: HBase
> Issue Type: Improvement
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Priority: Minor
> Attachments: HBASE-19621.master.001.patch
>
>
> Add 4 methods for ReplicationPeerConfigBuilder:
> addConfiguration
> addAllConfiguration
> addPeerData
> addAllPeerData
> Meanwhile, remove setConfiuration and serPeerData from
> ReplicationPeerConfigBuilder.
> Because previous ReplicationPeerConfig didn't support setConfiuration and
> serPeerData. And previous code used getConfiguration.put or putAll to add
> configuration. So add methods to keep consistent with old usage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
