[
https://issues.apache.org/jira/browse/HBASE-19621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303814#comment-16303814
]
Ted Yu commented on HBASE-19621:
--------------------------------
In ReplicationPeersZKImpl#updatePeerConfig() :
{code}
ReplicationPeerConfigBuilder builder =
ReplicationPeerConfig.newBuilder(newConfig);
builder.putAllConfiguration(existingConfig.getConfiguration());
builder.putAllPeerData(existingConfig.getPeerData());
{code}
I think the above logic is incorrect - we shouldn't overwrite the newConfig
with existingConfig.
[~zghaobac]:
Can you check this part again ?
> Revisit the methods in ReplicationPeerConfigBuilder
> ---------------------------------------------------
>
> Key: HBASE-19621
> URL: https://issues.apache.org/jira/browse/HBASE-19621
> Project: HBase
> Issue Type: Improvement
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19621.master.001.patch,
> HBASE-19621.master.002.patch
>
>
> Add 4 methods for ReplicationPeerConfigBuilder:
> putConfiguration
> putAllConfiguration
> putPeerData
> putAllPeerData
> Meanwhile, remove setConfiuration and serPeerData from
> ReplicationPeerConfigBuilder.
> Because previous ReplicationPeerConfig didn't support setConfiuration and
> serPeerData. And previous code used getConfiguration.put or putAll to add
> configuration. So add methods to keep consistent with old usage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
