[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305045#comment-16305045
]
Reid Chan commented on HBASE-18309:
-----------------------------------
bq. I'll suppress these lines too.
Just do it, no objection. I used those to debug functionality, i should have
removed after done. I'll pay attention to that next time.
The reason, in {{CleanerChore}}.class method {{private boolean
checkAndDeleteFiles(List<FileStatus> files)}}
{code}
Iterable<FileStatus> filteredFiles =
cleaner.getDeletableFiles(deletableValidFiles);
...
return deleteFiles(filesToDelete) == files.size();
{code}
deletableFiles is not always equals to files.size(), based on each
implementation of {{CleanerDelegate}}. Do i make clear?
Those are from {{ReplicationLogCleaner}} not parts of this patch, i'm not sure
that logic.
> Support multi threads in CleanerChore
> -------------------------------------
>
> Key: HBASE-18309
> URL: https://issues.apache.org/jira/browse/HBASE-18309
> Project: HBase
> Issue Type: Improvement
> Reporter: binlijin
> Assignee: Reid Chan
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: HBASE-18309.addendum.patch,
> HBASE-18309.master.001.patch, HBASE-18309.master.002.patch,
> HBASE-18309.master.004.patch, HBASE-18309.master.005.patch,
> HBASE-18309.master.006.patch, HBASE-18309.master.007.patch,
> HBASE-18309.master.008.patch, HBASE-18309.master.009.patch,
> HBASE-18309.master.010.patch, HBASE-18309.master.011.patch,
> HBASE-18309.master.012.patch, space_consumption_in_archive.png
>
>
> There is only one thread in LogCleaner to clean oldWALs and in our big
> cluster we find this is not enough. The number of files under oldWALs reach
> the max-directory-items limit of HDFS and cause region server crash, so we
> use multi threads for LogCleaner and the crash not happened any more.
> What's more, currently there's only one thread iterating the archive
> directory, and we could use multiple threads cleaning sub directories in
> parallel to speed it up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
