[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306212#comment-16306212
]
Chia-Ping Tsai commented on HBASE-19662:
----------------------------------------
I run the same commend for hbase-metrics-api.
{code}
grep ImportOrderCheck hbase-metrics-api/target/checkstyle-result.xml | wc
0 0 0
{code}
The commit of HBASE-19552 are divided into 2 parts. If you build hbase on top
of ea7d5fc88454cc8d623d837e2d8975643e354bda, you will encounter the build
error. I believe the error is gone now.
{quote}
Maybe we should temporarily disable the import order rule.
What do you think ?
{quote}
I prefer to resolved all checkstyle issues....ya, a difficult job. There is a
related issue. HBASE-12521.
> hbase-metrics-api fails checkstyle due to wrong import order
> ------------------------------------------------------------
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
