[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order

[Chia-Ping Tsai (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307317#comment-16307317
 ] 

Chia-Ping Tsai commented on HBASE-19662:
----------------------------------------

Or use the full path instead.
{code}
           <version>${maven.checkstyle.version}</version>
           <dependencies>
             <dependency>
-              <groupId>org.apache.hbase</groupId>
-              <artifactId>hbase-checkstyle</artifactId>
-              <version>${project.version}</version>
-            </dependency>
-            <dependency>
               <groupId>com.puppycrawl.tools</groupId>
               <artifactId>checkstyle</artifactId>
               <version>${checkstyle.version}</version>
             </dependency>
           </dependencies>
           <configuration>
-            <configLocation>hbase/checkstyle.xml</configLocation>
-            
<suppressionsLocation>hbase/checkstyle-suppressions.xml</suppressionsLocation>
+            
<configLocation>hbase-checkstyle/src/main/resources/hbase/checkstyle.xml</configLocation>
+            
<suppressionsLocation>hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml</suppressionsLocation>
             <includeTestSourceDirectory>true</includeTestSourceDirectory>
           </configuration>
         </plugin>
{code}

> hbase-metrics-api fails checkstyle due to wrong import order
> ------------------------------------------------------------
>
>                 Key: HBASE-19662
>                 URL: https://issues.apache.org/jira/browse/HBASE-19662
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR] 
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
>  (imports) ImportOrder: Wrong order for 
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting' 
> import.
> [ERROR] 
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
>  (imports) ImportOrder: Wrong order for 
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)