[ https://issues.apache.org/jira/browse/HBASE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308465#comment-16308465 ]
Appy commented on HBASE-19500: ------------------------------ yayy... will review it today. > Make RSGroupInfo immutable > -------------------------- > > Key: HBASE-19500 > URL: https://issues.apache.org/jira/browse/HBASE-19500 > Project: HBase > Issue Type: Bug > Reporter: Appy > > HBASE-19483 added CP hooks to expose RSGroupInfo. > First, we should at least change [hbase-client] RSGroupInfo to immutable + > builder pattern like we have done for so many other things. > What say [~Apache9] > Then, few questions need figuring out: > - Should hooks be allowed to change RSGroupInfo. > Probably not? Then making it immutable would be necessary and sufficient > - Can we remove {{if(((MasterEnvironment)getEnvironment()).supportGroupCPs) > }} in so many places since CP in 2.0 are already broken left and right (and > we'll have to solve legacy issue more holistically) What say [~anoop.hbase]? -- This message was sent by Atlassian JIRA (v6.4.14#64029)