[
https://issues.apache.org/jira/browse/HBASE-19673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309329#comment-16309329
]
Chia-Ping Tsai commented on HBASE-19673:
----------------------------------------
{quote}
Where the 1.x needs a cast to the implementation (or the interface)
BufferedMutatorImpl mutatorImpl = (BufferedMutatorImpl)mutator;
mutatorImpl.setWriteBufferPeriodicFlush(100,100);
{quote}
BufferedMutatorImpl is IA.Private so it seems to me that encouraging user to
cast BM to BMI is not acceptable...
bq. Also note that this is a major version difference and therefor it is "ok"
to have API changes.
IIRC, we must deprecate the API before removing it. If
BufferedMutatorPeriodicFlush is in branch-1.x, we can't just remove it in 2.x
without any deprecation cycle.
> Backport " Periodically ensure records are not buffered too long by
> BufferedMutator" to branch-1
> ------------------------------------------------------------------------------------------------
>
> Key: HBASE-19673
> URL: https://issues.apache.org/jira/browse/HBASE-19673
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Reporter: Niels Basjes
> Assignee: Niels Basjes
> Attachments: HBASE-19673.20171230-130631.branch-1.patch,
> HBASE-19673.20171230-131955.branch-1.patch,
> HBASE-19673.20171231-112539.branch-1.patch,
> HBASE-19673.20180102-082937.branch-1.patch,
> HBASE-19673.20180102-155006.branch-1.patch,
> HBASE-19673.20180103-084857.branch-1.patch
>
>
> In HBASE-19486 the feature was built to periodically flush the
> BufferedMutator.
> Because backwards compatibility is important in the 1.x branch some
> refactoring is needed to make this work.
> As requested by [~chia7712] this separate issue was created
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
