[ 
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313011#comment-16313011
 ] 

Ankit Singhal commented on HBASE-19696:
---------------------------------------

bq.  Or can we make doneWithColumn() in ColumnTracker itself. Dont think it is 
that wrong. Only the ExplcitCT interested in it. But there is no harm informing 
all CTs that we are done with this column.
bq. I feel adding doneWithColumn() to ColumnTracker (with default 
implementation) is better than calling some method which may be modified in the 
future.

I have added doneWithColumn(Cell) in ColumnTracker, Currently, it is 
implemented for ExplicitColumnTracker so mentioned the same in the comments to 
avoid people misunderstanding it for other trackers.

> Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when 
> scan has explicit columns
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19696
>                 URL: https://issues.apache.org/jira/browse/HBASE-19696
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Critical
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19696.patch, HBASE-19696_v1.patch
>
>
> INCLUDE_AND_NEXT_COL from filter doesn't skip remaining versions of the cell 
> if the scan has explicit columns.
> This is because we use a column hint from a column tracker to prepare a cell 
> for seeking to next column but we are not updating column tracker with next 
> column when filter returns INCLUDE_AND_NEXT_COL.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to