[
https://issues.apache.org/jira/browse/HBASE-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311082#comment-16311082
]
Anoop Sam John commented on HBASE-19696:
----------------------------------------
Nice digging in Ankit.. Thanks for the great work.
On the call to getNextRowOrNextColumn() I have a concern though. What we
really want to do here is if it is ExplicitCT we would like to
doneWithColumn(cell). And u say that
bq. Actually, we just need to call ExplicitColumnTracker#doneWithColumn but
it's not availabe in ColumnTracker.
So we are relying on the side effect of another API call. I would say it would
be better if we do a type check and call the ExplicitCT method direct. Or can
we make doneWithColumn() in ColumnTracker itself. Dont think it is that wrong.
Only the ExplcitCT interested in it. But there is no harm informing all CTs
that we are done with this column. I mean at a design view. wdyt guys?
This is great testing happening for 2.0 from the Phoenix team.. Good on you
guys.
> Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when
> scan has explicit columns
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-19696
> URL: https://issues.apache.org/jira/browse/HBASE-19696
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0-beta-1
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19696.patch, HBASE-19696_v1.patch
>
>
> INCLUDE_AND_NEXT_COL from filter doesn't skip remaining versions of the cell
> if the scan has explicit columns.
> This is because we use a column hint from a column tracker to prepare a cell
> for seeking to next column but we are not updating column tracker with next
> column when filter returns INCLUDE_AND_NEXT_COL.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
