[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342321#comment-16342321
]
stack commented on HBASE-19873:
-------------------------------
{{Minor comment. Should CategoryBasedTimeout be called HBaseClassRule instead
and in each test we'd have}}
{{@ClassRule public static final HBaseClassRule CLASSRULE}}
... rather than....
@ClassRule public static final CategoryBasedTimeout TIMEOUT ?
The fact that we have a class in every unit test is an opportunity for doing
more than just timeout checking (looking for stuck threads though in the base
junit Timeout class, is sort of off the timeout topic already).
(On other hand, CategoryBasedTimeout "connects" with the Category annotation we
have on each test... )
Otherwise, +1. Can fix the broke rule checking in follow-on. I skimmed the
massive patch. If issue, can address in follow-on.
Please wait before committing to branch-2. I need to check w/ folks trying to
integrate branch-2... Or, perhaps, we just need to backport to branch-2 the
change in CategoryBasedTimeout.... And not the edit to every test? Thanks.
> Add a CategoryBasedTimeout ClassRule for all UTs
> ------------------------------------------------
>
> Key: HBASE-19873
> URL: https://issues.apache.org/jira/browse/HBASE-19873
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19873.patch
>
>
> So that our test can timeout as expected without making the surefire plugin
> kill other tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
