[ https://issues.apache.org/jira/browse/HBASE-19703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347297#comment-16347297 ]
Rajeshbabu Chintaguntla commented on HBASE-19703: ------------------------------------------------- [~chia7712] Thanks for the review. bq. Could you add some comments to remind reader the changes are for phoenix's local index? Added in the comment. bq. I afraid your fix will be destroyed in the future since the fix here is like a hacky way (instantiate a policy without region object...) Creating the split policy same as in RegionSplitPolicy#create with default constructor. bq. nit: splity -> split Done. > Functionality added as part of HBASE-12583 is not working after moving the > split code to master > ----------------------------------------------------------------------------------------------- > > Key: HBASE-19703 > URL: https://issues.apache.org/jira/browse/HBASE-19703 > Project: HBase > Issue Type: Bug > Reporter: Rajeshbabu Chintaguntla > Assignee: Rajeshbabu Chintaguntla > Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19703-WIP.patch, HBASE-19703_v2.patch, > HBASE-19703_v3.patch, HBASE-19703_v4.patch, HBASE-19703_v5.patch > > > As part of HBASE-12583 we are passing split policy to > HRegionFileSystem#splitStoreFile so that we can allow to create reference > files even the split key is out of HFile key range. This is needed for Local > Indexing implementation in Phoenix. But now after moving the split code to > master just passing null for split policy. > {noformat} > final String familyName = Bytes.toString(family); > final Path path_first = > regionFs.splitStoreFile(this.daughter_1_RI, familyName, sf, splitRow, > false, null); > final Path path_second = > regionFs.splitStoreFile(this.daughter_2_RI, familyName, sf, splitRow, > true, null); > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)