[ https://issues.apache.org/jira/browse/HBASE-5344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203286#comment-13203286 ]
Phabricator commented on HBASE-5344: ------------------------------------ stack has commented on the revision "[jira] [HBASE-5344] [89-fb] Scan unassigned region directory on master failover". I should work on the forward-port to trunk of this patch (it won't look much like this when done but there is some good stuff in here). INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/master/DirectRegionServerScanner.java:50 Nice. Should we do same in trunk? src/main/java/org/apache/hadoop/hbase/master/DirectRegionServerScanner.java:156 Single thread access in here only? src/main/java/org/apache/hadoop/hbase/master/HMaster.java:1207 This is interesting. YOu just trying to figure who called this method? src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java:62 We should do this in trunk too... src/main/java/org/apache/hadoop/hbase/master/HMaster.java:254 So, you'd do this rather than wait on the regionservers to report in? Via heartbeat? I need to glean from this patch stuff that will help our trunk story. REVISION DETAIL https://reviews.facebook.net/D1605 > [89-fb] Scan unassigned region directory on master failover > ----------------------------------------------------------- > > Key: HBASE-5344 > URL: https://issues.apache.org/jira/browse/HBASE-5344 > Project: HBase > Issue Type: Bug > Reporter: Mikhail Bautin > Assignee: Mikhail Bautin > Attachments: D1605.1.patch > > > In case the master dies after a regionserver writes region state as OPENED or > CLOSED in ZK but before the update is received by master and written to meta, > the new master that comes up has to pick up the region state from ZK and > write it to meta. Otherwise we can get multiply-assigned regions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira