[
https://issues.apache.org/jira/browse/HBASE-5344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208180#comment-13208180
]
Phabricator commented on HBASE-5344:
------------------------------------
Karthik has commented on the revision "[jira] [HBASE-5344] [89-fb] Scan
unassigned region directory on master failover".
Looks awesome! Couple of comments:
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/master/HMaster.java:254 Why do we
rescanRSDirectory() here? Is it only to figure out if this is a fresh cluster
start or not? Could we rename to checkIfFreshClusterStart()?
src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java:171 We
should set this to false only after draining the queue, otherwise an older
event could overwrite a newer one?
Might need something like:
while (true) {
synchronized (deferredLock) {
if (bufferedEvents.isEmpty()) {
deferRegionEventProcessing = false;
break;
}
else {
event = bufferedEvents.take();
}
}
process(event);
}
Need the lock on the queueing side as well.
REVISION DETAIL
https://reviews.facebook.net/D1605
> [89-fb] Scan unassigned region directory on master failover
> -----------------------------------------------------------
>
> Key: HBASE-5344
> URL: https://issues.apache.org/jira/browse/HBASE-5344
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D1605.1.patch
>
>
> In case the master dies after a regionserver writes region state as OPENED or
> CLOSED in ZK but before the update is received by master and written to meta,
> the new master that comes up has to pick up the region state from ZK and
> write it to meta. Otherwise we can get multiply-assigned regions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
