Anastasia Braginsky commented on HBASE-19930:

I have looked on the fix in the review board. The fix and its test looks good 
to me. +1 from my side.

Would like to hear from other committers, so the commit is not only based on 
one +1...  [~ram_krish], [~yuzhih...@gmail.com], [~anoop.hbase], [~chia7712], 
does anyone want to take another look on this review board before we commit?

> fix ImmutableMemStoreLAB#forceCopyOfBigCellInto
> -----------------------------------------------
>                 Key: HBASE-19930
>                 URL: https://issues.apache.org/jira/browse/HBASE-19930
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Gali Sheffi
>            Assignee: Gali Sheffi
>            Priority: Major
>         Attachments: HBASE-19930-V01.patch, HBASE-19930-V02.patch, 
> HBASE-19930-V03.patch, HBASE-19930-V04.patch
> This issue is about fixing ImmutableMemStoreLAB#forceCopyOfBigCellInto.
> Following a comment in HBASE-19133 regarding a bug in 
> ImmutableMemStoreLAB#forceCopyOfBigCellInto (assuming this method is never 
> called for an ImmutableMemStoreLAB, and just throwing an 
> IllegalStateException whenever called), the forceCopyOfBigCellInto method now 
> performs the copy of big cells on the first MSLABImpl in its mslabs 
> linked-list.

This message was sent by Atlassian JIRA

Reply via email to