Anoop Sam John commented on HBASE-19930:

Same Q as Ram's.  Not sure how we will reach to such a call.  When the in 
memory flush happens to a CCM, then itself all cells (including any big cells) 
should get copied to MSLAB.  This ImmutableMemStoreLAB comes into picture when 
many Immutable segments are merged into one.  So then only we need this copy of 
big cells?  Or is it the case with non basic type? (data compaction not just 
index compaction?)

> fix ImmutableMemStoreLAB#forceCopyOfBigCellInto
> -----------------------------------------------
>                 Key: HBASE-19930
>                 URL: https://issues.apache.org/jira/browse/HBASE-19930
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Gali Sheffi
>            Assignee: Gali Sheffi
>            Priority: Major
>         Attachments: HBASE-19930-V01.patch, HBASE-19930-V02.patch, 
> HBASE-19930-V03.patch, HBASE-19930-V04.patch
> This issue is about fixing ImmutableMemStoreLAB#forceCopyOfBigCellInto.
> Following a comment in HBASE-19133 regarding a bug in 
> ImmutableMemStoreLAB#forceCopyOfBigCellInto (assuming this method is never 
> called for an ImmutableMemStoreLAB, and just throwing an 
> IllegalStateException whenever called), the forceCopyOfBigCellInto method now 
> performs the copy of big cells on the first MSLABImpl in its mslabs 
> linked-list.

This message was sent by Atlassian JIRA

Reply via email to