[ 
https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362128#comment-16362128
 ] 

Hadoop QA commented on HBASE-19979:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} 
| {color:red} HBASE-19979 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19979 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12910373/HBASE-19979.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11508/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> ReplicationSyncUp tool may leak Zookeeper connection
> ----------------------------------------------------
>
>                 Key: HBASE-19979
>                 URL: https://issues.apache.org/jira/browse/HBASE-19979
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 1.5.0
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Major
>         Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch
>
>
> ReplicationSyncUp tool may leak Zookeeper connection in the following code 
> snippet,
> {code}
>     try {
>       int numberOfOldSource = 1; // default wait once
>       while (numberOfOldSource > 0) {
>         Thread.sleep(SLEEP_TIME);
>         numberOfOldSource = manager.getOldSources().size();
>       }
>     } catch (InterruptedException e) {
>       System.err.println("didn't wait long enough:" + e);
>       return (-1);
>     }
>     manager.join();
>     zkw.close();
> {code}
> ZooKeeperWatcher will not be closed in case of InterruptedException.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to