[
https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363497#comment-16363497
]
Pankaj Kumar commented on HBASE-19979:
--------------------------------------
Thanks everyone for reviewing and committing this fix.
Can we have this fix in branch-1.3.x as well?
> ReplicationSyncUp tool may leak Zookeeper connection
> ----------------------------------------------------
>
> Key: HBASE-19979
> URL: https://issues.apache.org/jira/browse/HBASE-19979
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Reporter: Pankaj Kumar
> Assignee: Pankaj Kumar
> Priority: Major
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch
>
>
> ReplicationSyncUp tool may leak Zookeeper connection in the following code
> snippet,
> {code}
> try {
> int numberOfOldSource = 1; // default wait once
> while (numberOfOldSource > 0) {
> Thread.sleep(SLEEP_TIME);
> numberOfOldSource = manager.getOldSources().size();
> }
> } catch (InterruptedException e) {
> System.err.println("didn't wait long enough:" + e);
> return (-1);
> }
> manager.join();
> zkw.close();
> {code}
> ZooKeeperWatcher will not be closed in case of InterruptedException.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
