[ 
https://issues.apache.org/jira/browse/HBASE-19157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374725#comment-16374725
 ] 

Ted Yu commented on HBASE-19157:
--------------------------------

{code}
+   * @return
+   * @throws IOException
+   */
   protected boolean checkSucceeded(String backupId) throws IOException {
{code}
Please add what is returned following the @return
{code}
+   * @param backupRootDir
+   * @param backupId
{code}
If you don't plan to explain each parameter, there is no need to add the 
javadoc.

> IntegrationTestBackupRestore should warn about missing config
> -------------------------------------------------------------
>
>                 Key: HBASE-19157
>                 URL: https://issues.apache.org/jira/browse/HBASE-19157
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Artem Ervits
>            Priority: Minor
>              Labels: backup, integration-test
>         Attachments: HBASE-19157.v01.patch
>
>
> I was running IntegrationTestBackupRestore on a newly created cluster running 
> hbase-2.
> It failed with:
> {code}
> Caused by: 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
>  org.apache.hadoop.hbase.DoNotRetryIOException: The procedure is not 
> registered: rolllog-proc
>       at 
> org.apache.hadoop.hbase.master.MasterRpcServices.execProcedure(MasterRpcServices.java:817)
>       at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>       at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>       at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
>       at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
>       at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}
> {{hbase backup}} command warns about missing config up-front.
> IntegrationTestBackupRestore should do the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to