[
https://issues.apache.org/jira/browse/HBASE-19157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374862#comment-16374862
]
Artem Ervits commented on HBASE-19157:
--------------------------------------
[[email protected]] addressing some of your concerns, though I think for
tests running as part of IT, it doesn't make sense to check as
[https://github.com/apache/hbase/blob/f572c4b80e2bef91f582ed5b535c4ba695d63a2d/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBackupRestore.java#L92]
makes sure backup property is enabled so I should only handle the situation
where tests are executed as part of command line execution
https://github.com/apache/hbase/blob/f572c4b80e2bef91f582ed5b535c4ba695d63a2d/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBackupRestore.java#L260
> IntegrationTestBackupRestore should warn about missing config
> -------------------------------------------------------------
>
> Key: HBASE-19157
> URL: https://issues.apache.org/jira/browse/HBASE-19157
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Artem Ervits
> Priority: Minor
> Labels: backup, integration-test
> Attachments: HBASE-19157.v01.patch, HBASE-19157.v02.patch
>
>
> I was running IntegrationTestBackupRestore on a newly created cluster running
> hbase-2.
> It failed with:
> {code}
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> org.apache.hadoop.hbase.DoNotRetryIOException: The procedure is not
> registered: rolllog-proc
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execProcedure(MasterRpcServices.java:817)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}
> {{hbase backup}} command warns about missing config up-front.
> IntegrationTestBackupRestore should do the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
