[ 
https://issues.apache.org/jira/browse/HBASE-20052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375238#comment-16375238
 ] 

Ted Yu commented on HBASE-20052:
--------------------------------

HRegionFileSystem#createRegionOnFileSystem() is used in several tests, not just 
in hbase2+ :
{code}
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV1.java:
      HRegionFileSystem snapshotRegionFs = 
HRegionFileSystem.createRegionOnFileSystem(conf,
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java:
    HRegionFileSystem regionFs = 
HRegionFileSystem.createRegionOnFileSystem(conf, fs
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java:
    HRegionFileSystem regionFs = 
HRegionFileSystem.createRegionOnFileSystem(conf, fs
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java:
    // HRegionFileSystem.createRegionOnFileSystem(conf, new 
MockFileSystemForCreate(
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java:
    HRegionFileSystem regionFs = 
HRegionFileSystem.createRegionOnFileSystem(conf, fs
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java:
    HRegionFileSystem regionFs = 
HRegionFileSystem.createRegionOnFileSystem(conf, fs,
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java:
    HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java:
    HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java:
    HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java:
    HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java:
    HRegionFileSystem cloneRegionFs = 
HRegionFileSystem.createRegionOnFileSystem(
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java:
        HRegionFileSystem rfs = 
HRegionFileSystem.createRegionOnFileSystem(conf, fs, tabl
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java:
        rfs = HRegionFileSystem.createRegionOnFileSystem(conf, fs, tableDir, 
hri);
{code}
The above is from branch-1.

If return type for the method is to be changed, another JIRA should be opened.

> TestRegionOpen#testNonExistentRegionReplica fails due to NPE
> ------------------------------------------------------------
>
>                 Key: HBASE-20052
>                 URL: https://issues.apache.org/jira/browse/HBASE-20052
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>             Fix For: 1.5.0, 2.0.0-beta-2, 1.4.3
>
>         Attachments: 20052.v1.txt, 20052.v2.txt
>
>
> After HBASE-19391 was integrated, the following test failure can be observed:
> {code}
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hbase.regionserver.TestRegionOpen.testNonExistentRegionReplica(TestRegionOpen.java:122)
> {code}
> This was due null being returned from 
> HRegionFileSystem#createRegionOnFileSystem().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to