[
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375411#comment-16375411
]
Zheng Hu commented on HBASE-20065:
----------------------------------
#1
{code}
/**
* @param t Table to use (will be closed when done).
* @param p put to make
- * @throws IOException
*/
- private static void put(final Table t, final Put p) throws IOException {
- try {
- debugLogMutation(p);
- t.put(p);
- } finally {
- t.close();
- }
+ private static void put(Table t, Put p) throws IOException {
+ debugLogMutation(p);
+ t.put(p);
}
{code}
The javadoc mismatched the implementation ?
#2
Why we use Long.MAX_VALUE as the ts in HBaseFsck.java ? IMHO, should use
current timestamp (or a future timestamp slight large than the current ts to
make sure the region info from HBCK to be the latest) ?
> Revisit the timestamp usage in MetaTableAccessor
> ------------------------------------------------
>
> Key: HBASE-20065
> URL: https://issues.apache.org/jira/browse/HBASE-20065
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Attachments: HBASE-20065.patch
>
>
> It is totally a mess and makes me confusing when reimplementing the serial
> replication feature. Let me do a clean up first.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
