[
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376004#comment-16376004
]
stack commented on HBASE-20065:
-------------------------------
Nice cleanup.
Why not let the server set the time rather than do it in client:
1449 Put put = makePutFromRegionInfo(regionInfo,
EnvironmentEdgeManager.currentTime());
... previous we did not pass a time.
Yeah, it is done again later in the class when we remove this and pass
currentTime instead...
addRegionsToMeta(connection, regionInfos, regionReplication,
HConstants.LATEST_TIMESTAMP);
This could go badly wrong if a new Master has a clock that is behind that of
the server hosting hbase:meta.
nit: Comment is wrong here now...
1531 // use the maximum of what master passed us vs local time.
1595 long time = Math.max(EnvironmentEdgeManager.currentTime(),
masterSystemTime); 1532 long time =
EnvironmentEdgeManager.currentTime();
Not sure what was going on before... we had a master time?
Removing this is nice cleanup.
225 // Start the RegionStateStore
226 regionStateStore.start();
HBCK doesn't work against hbase2 and setting time on client-side seems
problematic to me.
Otherwise, really nice cleanup. I like the removal of unused overrides.
> Revisit the timestamp usage in MetaTableAccessor
> ------------------------------------------------
>
> Key: HBASE-20065
> URL: https://issues.apache.org/jira/browse/HBASE-20065
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20065-v1.patch, HBASE-20065.patch
>
>
> It is totally a mess and makes me confusing when reimplementing the serial
> replication feature. Let me do a clean up first.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
