[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375839#comment-16375839
]
Mike Drob commented on HBASE-20069:
-----------------------------------
I think the dead store in MutliButeBuf needs to be addressed by using it on
line 297. Probably need to review the logic there more closely to potentially
match lines 233-5.
In CleanerChore, I think we want a lazy init singleton pattern.
WakeupFlushToken could be a final class, I think. We're trying to emulate a
singleton without using an enum? should add a private constructor and have a
static instance variable. equals can check for reference equality then.
I don't like us manually throwing NPE in AsyncFSWAL. Better would be something
like {{writer = Preconditions.checkNotNull(nextWriter);}}
> fix existing findbugs errors in hbase-server
> --------------------------------------------
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
> Issue Type: Sub-task
> Components: findbugs
> Reporter: Sean Busbey
> Assignee: stack
> Priority: Critical
> Attachments: FindBugs Report.htm, HBASE-20069.branch-2.001.patch
>
>
> now that findbugs is running on precommit we have some cleanup to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
