[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375857#comment-16375857
]
Hadoop QA commented on HBASE-20069:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
28s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
18s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
45s{color} | {color:red} hbase-common in branch-2 has 2 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
31s{color} | {color:red} hbase-procedure in branch-2 has 2 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
37s{color} | {color:red} hbase-server in branch-2 has 22 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
16s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
31s{color} | {color:red} hbase-server: The patch generated 3 new + 753
unchanged - 0 fixed = 756 total (was 753) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
55s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 37s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
54s{color} | {color:green} hbase-common generated 0 new + 0 unchanged - 2 fixed
= 0 total (was 2) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
39s{color} | {color:green} hbase-procedure generated 0 new + 0 unchanged - 2
fixed = 0 total (was 2) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
32s{color} | {color:red} hbase-server generated 3 new + 5 unchanged - 17 fixed
= 8 total (was 22) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
35s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
4s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}111m 11s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
58s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}169m 28s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | org.apache.hadoop.hbase.regionserver.MemStoreFlusher$WakeupFlushThread
defines equals and uses Object.hashCode() At
MemStoreFlusher.java:Object.hashCode() At MemStoreFlusher.java:[line 802] |
| | Possible null pointer dereference of commandLine in
org.apache.hadoop.hbase.util.compaction.MajorCompactor.main(String[])
Dereferenced at MajorCompactor.java:commandLine in
org.apache.hadoop.hbase.util.compaction.MajorCompactor.main(String[])
Dereferenced at MajorCompactor.java:[line 344] |
| | Possible null pointer dereference of commandLine in
org.apache.hadoop.hbase.util.compaction.MajorCompactor.main(String[]) on
exception path Dereferenced at MajorCompactor.java:commandLine in
org.apache.hadoop.hbase.util.compaction.MajorCompactor.main(String[]) on
exception path Dereferenced at MajorCompactor.java:[line 344] |
| Failed junit tests | hadoop.hbase.mob.TestExpiredMobFileCleaner |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-20069 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12911928/HBASE-20069.branch-2.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 84461e48e108 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / 62b8da927e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/11661/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/11661/artifact/patchprocess/branch-findbugs-hbase-procedure-warnings.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/11661/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/11661/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/11661/artifact/patchprocess/new-findbugs-hbase-server.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/11661/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11661/testReport/ |
| Max. process+thread count | 5127 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-procedure hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11661/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> fix existing findbugs errors in hbase-server
> --------------------------------------------
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
> Issue Type: Sub-task
> Components: findbugs
> Reporter: Sean Busbey
> Assignee: stack
> Priority: Critical
> Attachments: FindBugs Report.htm, HBASE-20069.branch-2.001.patch
>
>
> now that findbugs is running on precommit we have some cleanup to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
