[ 
https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375983#comment-16375983
 ] 

stack commented on HBASE-18467:
-------------------------------

Dropping the env is right here:

         if [ "${BRANCH_NAME}" == "branch-1.1" ]; then

... it had been if [ "${env.BRANCH_NAME}" == "branch-1.1" ]; then

This code is copying local what hbase_nightly_yetus.sh did... was wondering why?

139             sh '''#!/usr/bin/env bash
140               declare commentfile
141               rm -rf "${OUTPUT_DIR}/success}" "${OUTPUT_DIR}/failure"
142               if "${BASEDIR}/dev-support/hbase_nightly_yetus.sh" ; then
143                 commentfile="${OUTPUT_DIR}/success"
144                 echo '(/) {color:green}+1 general checks{color}' >> 
"${commentfile}"
145               else
146                 commentfile="${OUTPUT_DIR}/failure"
147                 echo '(x) {color:red}-1 general checks{color}' >> 
"${commentfile}"
148               fi
149               echo "-- For more information [see general 
report|${BUILD_URL}/General_Nightly_Build_Report/]" >> "${commentfile}"
150             '''

Looking forward to this going in. That jenkins scripting stuff looks fun w/ all 
them brackets and keywordings. +1 on trying it.

> nightly job needs to run all stages and then comment on jira
> ------------------------------------------------------------
>
>                 Key: HBASE-18467
>                 URL: https://issues.apache.org/jira/browse/HBASE-18467
>             Project: HBase
>          Issue Type: Improvement
>          Components: community, test
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>         Attachments: HBASE-18467.0.WIP.patch, HBASE-18467.0.patch, 
> HBASE-18467.1.patch, HBASE-18467.1.patch, HBASE-18467.2.patch, 
> HBASE-18467.3.patch
>
>
> follow on from HBASE-18147, need a post action that pings all newly-committed 
> jiras with result of the branch build



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to