[
https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376116#comment-16376116
]
Sean Busbey commented on HBASE-18467:
-------------------------------------
{quote}
Dropping the env is right here:
if [ "${BRANCH_NAME}" == "branch-1.1" ]; then
... it had been if [ "${env.BRANCH_NAME}" == "branch-1.1" ]; then
{quote}
Oh that's me missing a line in the rebase I think. Effectively it ends up being
the same result, but the {{env.}} version gets rewritten by jenkins and the
other one is a bash variable. I'll put that back. this code is getting removed
in HBASE-20075 anyways.
{quote}
This code is copying local what hbase_nightly_yetus.sh did... was wondering why?
139 sh '''#!/usr/bin/env bash
140 declare commentfile
141 rm -rf "${OUTPUT_DIR}/success}" "${OUTPUT_DIR}/failure"
142 if "${BASEDIR}/dev-support/hbase_nightly_yetus.sh" ; then
143 commentfile="${OUTPUT_DIR}/success"
144 echo ' +1 general checks' >> "${commentfile}"
145 else
146 commentfile="${OUTPUT_DIR}/failure"
147 echo ' -1 general checks' >> "${commentfile}"
148 fi
149 echo "-- For more information [see general
report|${BUILD_URL}/General_Nightly_Build_Report/]" >> "${commentfile}"
150 '''
{quote}
it needs to ensure that if hbase_nightly_yetus returns a failure that jenkins
doesn't see it. since there's already success/failure logic going on it also
starts writing the needed jira comments (the jira comments only provide a
pass/fail for each stage and not the full per-module output that the yetus
report has).
I could move this logic into the {{hbase_nightly_yetus.sh}} script though; I
believe all the environment variables used are already present there. Would
that be easier to maintain?
> nightly job needs to run all stages and then comment on jira
> ------------------------------------------------------------
>
> Key: HBASE-18467
> URL: https://issues.apache.org/jira/browse/HBASE-18467
> Project: HBase
> Issue Type: Improvement
> Components: community, test
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Attachments: HBASE-18467.0.WIP.patch, HBASE-18467.0.patch,
> HBASE-18467.1.patch, HBASE-18467.1.patch, HBASE-18467.2.patch,
> HBASE-18467.3.patch
>
>
> follow on from HBASE-18147, need a post action that pings all newly-committed
> jiras with result of the branch build
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
