[ https://issues.apache.org/jira/browse/HBASE-20070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377432#comment-16377432 ]
Sean Busbey commented on HBASE-20070: ------------------------------------- Read through the {{HBASE-20070.misty.patch}} and it looks pretty similar to what I already have posted. It's still ignoring when commands fail unless they're expressly checked for, which I'd really like to avoid. {code} +PUSHED=$(git log -pretty=%H | grep ${CURRENT_HBASE_COMMIT}) {code} this is still relying on the format string and then matching output when all we need to know is if a commit exists. why go through the extra work? > website generation is failing > ----------------------------- > > Key: HBASE-20070 > URL: https://issues.apache.org/jira/browse/HBASE-20070 > Project: HBase > Issue Type: Bug > Components: website > Reporter: Sean Busbey > Assignee: Sean Busbey > Priority: Blocker > Attachments: HBASE-20070-misty.patch, HBASE-20070.0.patch, > HBASE-20070.1.patch, > hbase-build-log-a29b3caf4dbc7b8833474ef5da5438f7f6907e00.txt > > > website generation has been failing since Feb 20th > {code} > Checking out files: 100% (68971/68971), done. > Usage: grep [OPTION]... PATTERN [FILE]... > Try 'grep --help' for more information. > PUSHED is 2 > is not yet mentioned in the hbase-site commit log. Assuming we don't have it > yet. 2 > Building HBase > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Failure: mvn clean site > Build step 'Execute shell' marked build as failure > {code} > The status email says > {code} > Build status: Still Failing > The HBase website has not been updated to incorporate HBase commit > ${CURRENT_HBASE_COMMIT}. > {code} > Looking at the code where that grep happens, it looks like the env variable > CURRENT_HBASE_COMMIT isn't getting set. That comes from some git command. I'm > guessing the version of git changed on the build hosts and upended our > assumptions. > we should fix this to 1) rely on git's porcelain interface, and 2) fail as > soon as that git command fails -- This message was sent by Atlassian JIRA (v7.6.3#76005)