Sean Busbey commented on HBASE-20070:

bq. Nice usage function.


bq. <doclint>none</doclint> in general properties gets picked up by javadoc? 
Thats good.

yep. There was some talk in the {{maven-javadoc-plugin}} community about making 
the name better scoped, i.e. {{maven.javadoc.doclint}}, but AFAICT that change 
never happened. I really like that this property gets picked up both in the 
normal lifecycle ({{javadoc:javadoc}}) and in the site reporting section.

This was just noise?

168     #echo "Dumping current environment:"    
169     #env
Since it was commented out I figured best to just remove it. I can add it back 
if you prefer. We should really have the job use the "gather machine stats" 
script if we want that kind of info though.

...and this unnecessary work?

160     git fetch origin        
161     git reset --hard origin/asf-site

yeah, we were doing it at the end but we do a fresh clone every run.

Is this meant to be commented out?

275     #if git push origin asf-site; then

That's been commented out to ensure I don't push to the remote. I'll make it 
not commented out before pushing. I can update the patch with that change in 
place if folks prefer.

> website generation is failing
> -----------------------------
>                 Key: HBASE-20070
>                 URL: https://issues.apache.org/jira/browse/HBASE-20070
>             Project: HBase
>          Issue Type: Bug
>          Components: website
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>         Attachments: HBASE-20070-misty.patch, HBASE-20070-misty.patch.1, 
> HBASE-20070-misty.patch.3, HBASE-20070.0.patch, HBASE-20070.1.patch, 
> HBASE-20070.2.patch, HBASE-20070.3.patch, HBASE-20070.4.patch, 
> HBASE-20070.5.patch, HBASE-20070.6.patch, 
> hbase-install-log-a29b3caf4dbc7b8833474ef5da5438f7f6907e00.txt
> website generation has been failing since Feb 20th
> {code}
> Checking out files: 100% (68971/68971), done.
> Usage: grep [OPTION]... PATTERN [FILE]...
> Try 'grep --help' for more information.
> PUSHED is 2
>  is not yet mentioned in the hbase-site commit log. Assuming we don't have it 
> yet. 2
> Building HBase
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
> support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
> support was removed in 8.0
> Failure: mvn clean site
> Build step 'Execute shell' marked build as failure
> {code}
> The status email says
> {code}
> Build status: Still Failing
> The HBase website has not been updated to incorporate HBase commit 
> {code}
> Looking at the code where that grep happens, it looks like the env variable 
> CURRENT_HBASE_COMMIT isn't getting set. That comes from some git command. I'm 
> guessing the version of git changed on the build hosts and upended our 
> assumptions.
> we should fix this to 1) rely on git's porcelain interface, and 2) fail as 
> soon as that git command fails

This message was sent by Atlassian JIRA

Reply via email to