[ 
https://issues.apache.org/jira/browse/HBASE-19969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390437#comment-16390437
 ] 

Ted Yu commented on HBASE-19969:
--------------------------------

{code}
+   * Get tmp directory
{code}
Add backup after 'Get'
{code}
+   * @param backupRootDir
{code}
I don't think the above passes checkstyle
{code}
+      //TODO run job on remote cluster
{code}
Do you want to implement in this JIRA ?
{code}
+import org.mortbay.log.Log;
{code}
I don't think the above is right - we use org.slf4j
{code}
-  private static class DeleteCommand extends Command {
+  public static class DeleteCommand extends Command {
{code}
Is the change to public for testing ?
{code}
+      //System.out.println("Running MERGE again ...");
{code}
Drop commented out code.
{code}
+        if (!fs.delete(destPath, true)) {
+          System.out.println("Failed to delete " + destPath);
{code}
If we get into the if block, the rename() call below would fail, right ?
{code}
+//      if (runMergeAgain) {
+//        try (BackupAdmin admin = new BackupAdminImpl(conn)) {
+//          admin.mergeBackups(backupIds);
+//        }
+//      }
{code}
Drop commented out code.

Please address checkstyle, findbugs warnings.

Will continue reviewing.

> Improve FT in merge operation
> -----------------------------
>
>                 Key: HBASE-19969
>                 URL: https://issues.apache.org/jira/browse/HBASE-19969
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Major
>         Attachments: HBASE-19969-v1.patch
>
>
> Some file system operations are not fault tolerant during merge. We delete 
> backup data in a backup file system, then copy new data over to backup 
> destination. Deletes can be partial, copy can fail as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to