[ https://issues.apache.org/jira/browse/HBASE-19969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391531#comment-16391531 ]
Ted Yu commented on HBASE-19969: -------------------------------- One more comment about the new test : {code} + LOG.debug("f1 has " + TEST_UTIL.countRows(hTable, famName) + " rows"); + Assert.assertEquals(TEST_UTIL.countRows(hTable, famName), NB_ROWS_IN_BATCH + 2 * ADD_ROWS); {code} You can store the return value from TEST_UTIL.countRows() in a variable. The count would not change in between the log and the assertion. I looped the following tests locally which passed: {code} [INFO] Running org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 201.72 s - in org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures [INFO] Running org.apache.hadoop.hbase.backup.TestBackupMerge [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 164.286 s - in org.apache.hadoop.hbase.backup.TestBackupMerge {code} > Improve FT in merge operation > ----------------------------- > > Key: HBASE-19969 > URL: https://issues.apache.org/jira/browse/HBASE-19969 > Project: HBase > Issue Type: Sub-task > Reporter: Vladimir Rodionov > Assignee: Vladimir Rodionov > Priority: Major > Attachments: HBASE-19969-v1.patch > > > Some file system operations are not fault tolerant during merge. We delete > backup data in a backup file system, then copy new data over to backup > destination. Deletes can be partial, copy can fail as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)