[ 
https://issues.apache.org/jira/browse/HBASE-19598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391310#comment-16391310
 ] 

Duo Zhang commented on HBASE-19598:
-----------------------------------

The problem maybe that we update the RIT metrics in a chore, the default update 
interval is 5 seconds. So if we are lucky that the chore update the metrics 
before we check then we are safe, otherwise we are dead.

After I added this line in the setup method

{code}
conf.setInt(AssignmentManager.RIT_CHORE_INTERVAL_MSEC_CONF_KEY, 600000);
{code}

The test fails consistently for me.

So I think we should set a small value (1000 maybe) for this value, and after 
returning from the modifyTable, we sleep 2 times of the interval, and then go 
to check the metrics.

What do you think [~stack]?

> Fix TestAssignmentManagerMetrics flaky test
> -------------------------------------------
>
>                 Key: HBASE-19598
>                 URL: https://issues.apache.org/jira/browse/HBASE-19598
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Balazs Meszaros
>            Assignee: stack
>            Priority: Major
>         Attachments: HBASE-19598.master.001.patch, 
> HBASE-19598.master.002.patch, HBASE-19598.master.003.patch, 
> HBASE-19598.master.003.patch, HBASE-19598.master.004.patch, TestUtil.java
>
>
> TestAssignmentManagerMetrics fails constantly. After bisecting, it seems that 
> commit 010012cbcb broke it (HBASE-18946).
> The test method runs successfully, but it cannot shut the minicluster down, 
> and hangs forever.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to