[ 
https://issues.apache.org/jira/browse/HBASE-20153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395595#comment-16395595
 ] 

Josh Elser commented on HBASE-20153:
------------------------------------

Just to confirm my understanding: I see lots of nice warnings from errorprone 
in the compilation phase. I assume we'll also get ERRORs that will crop up on 
definitively heinous issues? My only concern is making sure that will propagate 
up through the PreCommit summary.

I have a hard time thinking something else would happen, so I am happy to +1 
now :)

> enable error-prone analysis in precommit
> ----------------------------------------
>
>                 Key: HBASE-20153
>                 URL: https://issues.apache.org/jira/browse/HBASE-20153
>             Project: HBase
>          Issue Type: Bug
>          Components: community
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Major
>         Attachments: HBASE-20153.patch
>
>
> We've done a lot of work to get rid of the error-prone errors, we should make 
> sure they stay out. Let's enable errorProne profile and analysis in precommit.
> [~busbey] - I tried figuring out how to pass flags ({{-PerrorProne}} to the 
> mvn compile precommit check but was unable to unravel that thread. Any help 
> is appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to