[ 
https://issues.apache.org/jira/browse/HBASE-20153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396344#comment-16396344
 ] 

Andrew Purtell commented on HBASE-20153:
----------------------------------------

I picked this into branch-1.4. Let's start using this for 1.4.3. 

In the first pass over branch-1 after we backported error-prone support there 
were a few ERRORs that were resolved as part of that work. I remember some 
broken misuse of protobuf APIs, self comparisons, and I think attempts to get 
objects from collections using the wrong key type, String vs Address, 
definitely bad stuff. 

> enable error-prone analysis in precommit
> ----------------------------------------
>
>                 Key: HBASE-20153
>                 URL: https://issues.apache.org/jira/browse/HBASE-20153
>             Project: HBase
>          Issue Type: Bug
>          Components: community
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Major
>             Fix For: 2.0.0, 1.5.0, 1.4.3
>
>         Attachments: HBASE-20153.patch
>
>
> We've done a lot of work to get rid of the error-prone errors, we should make 
> sure they stay out. Let's enable errorProne profile and analysis in precommit.
> [~busbey] - I tried figuring out how to pass flags ({{-PerrorProne}} to the 
> mvn compile precommit check but was unable to unravel that thread. Any help 
> is appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to