[
https://issues.apache.org/jira/browse/HBASE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207080#comment-13207080
]
stack commented on HBASE-5325:
------------------------------
Does this need to be public? Can it be protected in AM?
{code}
+ public ServerName getServerName() {
{code}
Is the above even used?
Please file an issue to move +import org.apache.hadoop.metrics.util.MBeanUtil;
to o.a.h.h.u after this patch goes in (Seems like a silly place for this class
-- not your fault I know)
I think this is better for a name:
{code}
+ MBeanUtil.registerMBean("org.apache.hadoop.hbase", "Master", mxBeanInfo);
{code}
... maybe o.a.hbase instead of o.a.h.h (the o.a.hadoop prefix is legacy we'll
undo one day).
This bean is new, right? So its ok giving it a name like this?
Needs a class comment: '+public class MasterMXBeanImpl implements MasterMXBean
{'
Do you think we need to add an isActiveMaster attribute? What if the master is
not active? Will it show in jmx? If not, then no need of such an attribute.
Do you think this Interface belongs in Metrics?
src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMXBean.java
Its more than just metrics, right? Maybe should be in master package (Sorry,
should have said that in previous review)
Why not call it RegionServerMXBeanImpl.java or just MXBeanImpl (here and in
master package)?
I see now why no class comment on the Impl; its because you have class comment
on the Interface. Thats fine.
Do you have to do this getHBaseMaster with all of the messing to construct a
master name (and its not right anyways since master has its service port, not
its UI port when its name is made.... Leave it out I'd say... users can get the
info in zk.
Good stuff
> Expose basic information about the master-status through jmx beans
> -------------------------------------------------------------------
>
> Key: HBASE-5325
> URL: https://issues.apache.org/jira/browse/HBASE-5325
> Project: HBase
> Issue Type: Improvement
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5325.1.patch, HBASE-5325.2.patch,
> HBASE-5325.wip.patch
>
>
> Similar to the Namenode and Jobtracker, it would be good if the hbase master
> could expose some information through mbeans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
