[
https://issues.apache.org/jira/browse/HBASE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207241#comment-13207241
]
Hitesh Shah commented on HBASE-5325:
------------------------------------
@Stack, thanks for the review comments. Couple of clarifications/questions:
bq. Does this need to be public? Can it be protected in AM?
- This was added to RegionState to expose the private field ServerName for
display with regions in transition.
- Noticed that it can be null so will make a minor mod to handle the null
case.
bq. Please file an issue to move +import
org.apache.hadoop.metrics.util.MBeanUtil; to o.a.h.h.u
- Didn't understand this - could you clarify as MBeanUtil is part of
hadoop-core?
bq. maybe o.a.hbase instead of o.a.h.h
- Will change.
bq. isMasterActive
- will add.
bq. Do you think this Interface belongs in Metrics? Why not call it
RegionServerMXBeanImpl.java or just MXBeanImpl
- will move the interfaces to master and regionserver respectively.
- will change to call them MXBean and MXBeanImpl in both master and
regionserver as the package names already denote what kind of object the bean
represents.
bq. Do you have to do this getHBaseMaster with all of the messing to construct
a master name
- Will replace with the zk quorum info if that seems appropriate.
> Expose basic information about the master-status through jmx beans
> -------------------------------------------------------------------
>
> Key: HBASE-5325
> URL: https://issues.apache.org/jira/browse/HBASE-5325
> Project: HBase
> Issue Type: Improvement
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5325.1.patch, HBASE-5325.2.patch,
> HBASE-5325.wip.patch
>
>
> Similar to the Namenode and Jobtracker, it would be good if the hbase master
> could expose some information through mbeans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
