[
https://issues.apache.org/jira/browse/HBASE-20111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410132#comment-16410132
]
Josh Elser commented on HBASE-20111:
------------------------------------
{code}
+ // Even after setting force split if split policy says no to split
then we should not split.
+ shouldSplit =
+ region.getSplitPolicy().shouldSplit()
+ && !(info.isMetaRegion() &&
TableName.NAMESPACE_TABLE_NAME.equals(info.getTable()));
{code}
Don't you want this to be: {{!(info.isMetaRegion() ||
TableName.NAMESPACE_TABLE_NAME.equals(info.getTable()))}}? The part of the
conditional will never be true because {{isMetaRegion}} is only true for the
{{hbase:meta}} table.
I would have assumed that the hbase:namespace table is splittable too. So, this
should be something like...
{code}
+ // Even after setting force split if split policy says no to split
then we should not split.
+ shouldSplit =
+ region.getSplitPolicy().shouldSplit() && !region.isMetaRegion();
{code}
Not 100% sure
> Able to split region explicitly even on shouldSplit return false from split
> policy
> ----------------------------------------------------------------------------------
>
> Key: HBASE-20111
> URL: https://issues.apache.org/jira/browse/HBASE-20111
> Project: HBase
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20111.001.branch-2.0.patch, HBASE-20111.patch,
> HBASE-20111_test.patch, HBASE-20111_v2.patch
>
>
> Currently able to split the region explicitly even when the split policy
> returns from shouldSplit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
