[ 
https://issues.apache.org/jira/browse/HBASE-20111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415844#comment-16415844
 ] 

Ted Yu commented on HBASE-20111:
--------------------------------

{code}
+        // Even after setting force split if split policy says no to split 
then we should not split.
+        shouldSplit = region.getSplitPolicy().shouldSplit() && 
!(info.isMetaRegion());
         bestSplitRow = r.checkSplit();
{code}
{{checkSplit}} already has check w.r.t. system tables:
{code}
    if (this.getRegionInfo().isMetaRegion() ||
        TableName.NAMESPACE_TABLE_NAME.equals(this.getRegionInfo().getTable())) 
{
{code}
It seems {{shouldSplit}} should take into account the value of {{bestSplitRow}} 
- if {{bestSplitRow}} is null, {{shouldSplit}} should be false.

> Able to split region explicitly even on shouldSplit return false from split 
> policy
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-20111
>                 URL: https://issues.apache.org/jira/browse/HBASE-20111
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-20111.001.branch-2.0.patch, HBASE-20111.patch, 
> HBASE-20111_test.patch, HBASE-20111_v2.patch, HBASE-20111_v3.patch
>
>
> Currently able to split the region explicitly even when the split policy 
> returns from shouldSplit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to