[
https://issues.apache.org/jira/browse/HBASE-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208768#comment-13208768
]
Phabricator commented on HBASE-5241:
------------------------------------
aaiyer has commented on the revision "HBASE-5241 [jira] Deletes should not mask
Puts that come after it.".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:74
fixing this in the next version.
will update, once I fix the tests as well.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:189
I guess -1 or 0, both would work.
It seems to be initialized to -1L. But used to get reset to 0 on reset. That
didn't make sense.
Chose one at random.
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java:202
This is one perf penalty we pay for the better consistency semantics.
We can only zero-out memstoreTS upon major compaction. Not when all readers
get past the read point.
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java:845 that
was the initial direction.
I'm working on keeping things backward compatible. so this will get reverted.
REVISION DETAIL
https://reviews.facebook.net/D1731
> Deletes should not mask Puts that come after it.
> ------------------------------------------------
>
> Key: HBASE-5241
> URL: https://issues.apache.org/jira/browse/HBASE-5241
> Project: HBase
> Issue Type: Improvement
> Reporter: Amitanand Aiyer
> Attachments: HBASE-5241.D1731.1.patch
>
>
> Suppose that we have a delete row, and then followed by the put. The delete
> row
> can mask the put, unless there was a major compaction in between.
> Now that we are flushing the memstoreTS to disk, along with the KVs, we
> should be able
> to differentiate whether or not the Put happened after the Delete and offer
> better
> delete semantics.
> Couldn't find a pre-existing JIRA that already discusses this, so creating
> one.
> Seems related to https://issues.apache.org/jira/browse/HBASE-2406, but is not
> quite the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
