[
https://issues.apache.org/jira/browse/HBASE-5347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209105#comment-13209105
]
Phabricator commented on HBASE-5347:
------------------------------------
tedyu has commented on the revision "[HBASE-5347] [jira] GC free memory
management in Level-1 Block Cache".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/KeyValue.java:2193 Should we use some
timeout for the remove() call ?
remove() is a blocking call, see:
http://docs.oracle.com/javase/1.4.2/docs/api/java/lang/ref/ReferenceQueue.html#remove%28%29
Would the current code make the cleanup thread in region server less useful ?
src/main/java/org/apache/hadoop/hbase/KeyValue.java:2207 Please rename this
counter totKVOnRefQueue or something similar
src/main/java/org/apache/hadoop/hbase/KeyValue.java:2260 When would the
return value be used ?
src/main/java/org/apache/hadoop/hbase/KeyValue.java:2245 this.bytes is
cleared upon exit of deref().
Please document this in javadoc.
REVISION DETAIL
https://reviews.facebook.net/D1635
> GC free memory management in Level-1 Block Cache
> ------------------------------------------------
>
> Key: HBASE-5347
> URL: https://issues.apache.org/jira/browse/HBASE-5347
> Project: HBase
> Issue Type: Improvement
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: D1635.5.patch
>
>
> On eviction of a block from the block-cache, instead of waiting for the
> garbage collecter to reuse its memory, reuse the block right away.
> This will require us to keep reference counts on the HFile blocks. Once we
> have the reference counts in place we can do our own simple
> blocks-out-of-slab allocation for the block-cache.
> This will help us with
> * reducing gc pressure, especially in the old generation
> * making it possible to have non-java-heap memory backing the HFile blocks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
