[
https://issues.apache.org/jira/browse/HBASE-15466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429264#comment-16429264
]
Sean Busbey commented on HBASE-15466:
-------------------------------------
Running locally, looks like
{code:java}
+1 overall
____ _
/ ___| _ _ ___ ___ ___ ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
___) | |_| | (_| (_| __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| | | | Prechecks
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| | | | HBASE-15466 Compile Tests
| +1 | mvninstall | 5m 20s | HBASE-15466 passed
| 0 | refguide | 2m 45s | branch has no errors when building the
| | | | reference guide. See footer for rendered
| | | | docs, which you should manually inspect.
| | | | Patch Compile Tests
| +1 | whitespace | 0m 00s | The patch has no whitespace issues.
| 0 | refguide | 2m 29s | patch has no errors when building the
| | | | reference guide. See footer for rendered
| | | | docs, which you should manually inspect.
| | | | Other Tests
| +1 | asflicense | 0m 15s | The patch does not generate ASF License
| | | | warnings.
| | | 11m 08s |
|| Subsystem || Report/Notes ||
============================================================================
| Optional Tests | asflicense refguide |
| uname | Darwin Busbey-MBA 15.6.0 Darwin Kernel Version 15.6.0: Tue Jan 9
20:12:05 PST 2018; root:xnu-3248.73.5~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-15466 / 7069ccf33e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T02:58:13-05:00) |
| refguide | /private/tmp/yetus-25716.19351/branch-site/book.html |
| refguide | /private/tmp/yetus-25716.19351/patch-site/book.html |
| modules | C: . U: . |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
{code}
This example patch added an unresolvable inclusion. I can see it when looking
at the patch version of the HTML and when doing a simple diff
{code:java}
$ diff /private/tmp/yetus-25716.19351/branch-site/book.html
/private/tmp/yetus-25716.19351/patch-site/book.html
22964c22964,22965
< <p>Note: Path can specify scheme or not (e.g. <code><a
href="file:///usr/hbase/lib/coprocessors"
class="bare">file:///usr/hbase/lib/coprocessors</a></code> or for all
filesystems <code>/usr/hbase/lib/coprocessors</code>)</p>
---
> <p>Note: Path can specify scheme or not (e.g. <code><a
> href="file:///usr/hbase/lib/coprocessors"
> class="bare">file:///usr/hbase/lib/coprocessors</a></code> or for all
> filesystems <code>/usr/hbase/lib/coprocessors</code>)
> Unresolved directive in book.adoc - include::does/not/exist.adoc[]</p>
37632c37633
< Last updated 2018-04-07 01:54:35 CDT
---
> Last updated 2018-04-07 02:09:08 CDT
{code}
For a more complex change, I'd look at the HTML output and lean on a
description from the contributor to figure out which section to read.
> precommit should not run all java goals when given a docs-only patch
> --------------------------------------------------------------------
>
> Key: HBASE-15466
> URL: https://issues.apache.org/jira/browse/HBASE-15466
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Major
> Attachments: HBASE-15466.0.patch, HBASE-15466.1.patch,
> HBASE-15466.2.patch, HBASE-15466.3.patch
>
>
> Right now docs-only patches (those that only impact the top level
> src/main/site, src/main/asciidoc, or src/main/xslt) run through all of the
> java related precommit checks, including test4tests and the full unit test
> suite.
> Since we know these paths don't require those checks, we should update our
> personality to skip them. (or fix our project structure to match "the maven
> way".)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
