[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443214#comment-16443214
]
Sean Busbey commented on HBASE-20276:
-------------------------------------
switching to ruby 1.8 in branch-1 shows two issues:
{code}
$ ruby -v
ruby 1.8.7 (2013-06-27 patchlevel 374) [i686-darwin15.6.0]
$ for script in `find hbase-shell/src/main/ruby/ -name '*.rb'`; do ruby -c
${script}; done | grep -v "Syntax OK"
hbase-shell/src/main/ruby//hbase/table.rb:724: syntax error, unexpected '.',
expecting kEND
.map { |i| Bytes.toStringBinary...
^
hbase-shell/src/main/ruby//hbase/table.rb:725: syntax error, unexpected '.',
expecting kEND
.delete_if { |k| k == "" }
^
hbase-shell/src/main/ruby//shell/commands/get_splits.rb:42: syntax error,
unexpected ':', expecting ')'
numsplits: (splits.size + 1)))
^
hbase-shell/src/main/ruby//shell/commands/get_splits.rb:42: syntax error,
unexpected ')', expecting kEND
numsplits: (splits.size + 1)))
^
{code}
Apologies for the oversight. looks like no shell tests run in the default on
branch-1?
{code}
$ mvn -pl hbase-shell verify
16:28:31,056 [INFO] Scanning for projects...
16:28:33,172 [INFO]
16:28:33,172 [INFO]
------------------------------------------------------------------------
16:28:33,172 [INFO] Building Apache HBase - Shell 1.5.0-SNAPSHOT
16:28:33,172 [INFO]
------------------------------------------------------------------------
16:28:35,194 [INFO]
...
16:28:46,120 [INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @
hbase-shell ---
16:28:46,838 [INFO]
16:28:46,838 [INFO] -------------------------------------------------------
16:28:46,839 [INFO] T E S T S
16:28:46,839 [INFO] -------------------------------------------------------
16:28:50,146 [INFO]
16:28:50,146 [INFO] Results:
16:28:50,147 [INFO]
16:28:50,149 [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
16:28:50,150 [INFO]
16:28:50,162 [INFO]
16:28:50,163 [INFO] --- maven-surefire-plugin:2.20.1:test
(secondPartTestsExecution) @ hbase-shell ---
16:28:50,169 [INFO]
16:28:50,170 [INFO] -------------------------------------------------------
16:28:50,170 [INFO] T E S T S
16:28:50,170 [INFO] -------------------------------------------------------
16:28:52,152 [INFO]
16:28:52,152 [INFO] Results:
16:28:52,152 [INFO]
16:28:52,152 [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
16:28:52,152 [INFO]
...
16:28:53,269 [INFO]
------------------------------------------------------------------------
16:28:53,269 [INFO] BUILD SUCCESS
16:28:53,269 [INFO]
------------------------------------------------------------------------
16:28:53,270 [INFO] Total time: 22.241 s
16:28:53,270 [INFO] Finished at: 2018-04-18T16:28:53-05:00
16:28:53,598 [INFO] Final Memory: 54M/757M
16:28:53,600 [INFO]
------------------------------------------------------------------------
{code}
I'll try to fix that in a follow-on issue.
> [shell] Revert shell REPL change and document
> ---------------------------------------------
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
> Affects Versions: 1.4.0, 2.0.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
