[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443225#comment-16443225
]
Sean Busbey commented on HBASE-20276:
-------------------------------------
huh. okay. branch-1 has me confused.
syntax errors fixed:
{code}
$ ruby -v
ruby 1.8.7 (2013-06-27 patchlevel 374) [i686-darwin15.6.0]
$ for script in `find hbase-shell/src/main/ruby/ -name '*.rb'`; do ruby -c
${script}; done | grep -v "Syntax OK"
$
{code}
but tests all fail (when run with {{mvn -PrunAllTests -pl hbase-shell verify}})
with:
{code}
16:38:24,668 [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
elapsed: 10.458 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestShell
16:38:24,668 [ERROR]
testRunShellTests(org.apache.hadoop.hbase.client.TestShell) Time elapsed:
1.686 s <<< ERROR!
org.jruby.embed.EvalFailedException: (LoadError) no such file to load -- rake
at
org.apache.hadoop.hbase.client.TestShell.testRunShellTests(TestShell.java:36)
Caused by: org.jruby.exceptions.RaiseException: (LoadError) no such file to
load -- rake
{code}
Happens before my change too... digging in. I presume this means nightly is
broken too.
> [shell] Revert shell REPL change and document
> ---------------------------------------------
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
> Affects Versions: 1.4.0, 2.0.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch, HBASE-20276.1.patch,
> HBASE-20276.2.patch, HBASE-20276.3.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
