[
https://issues.apache.org/jira/browse/HBASE-20507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458216#comment-16458216
]
stack commented on HBASE-20507:
-------------------------------
This looks great [~Apache9] Makes sense to me. What does "overwritten" mean in
the above? We never overwrite a WAL? We roll and write the new? I am not
following. Fix me up. Thanks.
> Do not need to call recoverLease on the broken file when we fail to create a
> wal writer
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-20507
> URL: https://issues.apache.org/jira/browse/HBASE-20507
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Attachments: HBASE-20507.patch
>
>
> I tried locally with a UT, if we overwrite a file which is currently being
> written, the old file will be completed and then deleted. If you call close
> on the previous file, a no lease exception will be thrown which means that
> the file has already been completed.
> So we do not need to close a file if it will be overwritten immediately,
> since recoverLease may take a very long time...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
